Skip to content

wait for /dnsmasq.pid#80

Open
robertkirkman wants to merge 1 commit intotermux:masterfrom
robertkirkman:wait-for-dnsmasq.pid
Open

wait for /dnsmasq.pid#80
robertkirkman wants to merge 1 commit intotermux:masterfrom
robertkirkman:wait-for-dnsmasq.pid

Conversation

@robertkirkman
Copy link
Copy Markdown
Member

@robertkirkman
Copy link
Copy Markdown
Member Author

just some notes about this that may be relevant to whether this should be applied or not:

With this, if dnsmasq ever fails to start completely in the future again in some situation, it would freeze the container and not allow it to progress, instead of the current behavior which is allowing it to continue while printing a warning that DNS will not work.

however, all normal situations where dnsmasq could previously fail to start completely are thought to have been fixed after the recent changes:

so, it might be a very rare situation now. dnsmasq failing to start completely is also not the situation reported that this PR attempts to fix. If I'm not mistaken, the situation reported is simply that the current 1 second delay for dnsmasq is too short, and dnsmasq failed to activate in time to provide DNS immediately on running interactive commands in termux-docker shell.

I can't reproduce on my devices the issue this PR attempts to fix, so someone who still can will need to discuss this with me and help test this before we can decide what to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant