Skip to content

fix: update rocksdb version from v8.1.1 to v9.7.4 in external.cmake #35214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yihaoDeng wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

fix: update rocksdb version from v8.1.1 to v9.7.4 in external.cmake #35214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions cmake/external.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1148,12 +1148,12 @@ if (${BUILD_CONTRIB} OR NOT ${TD_LINUX}) # {
INC_DIR include
LIB ${CMAKE_INSTALL_LIBDIR}/${ext_rocksdb_static}
)
# URL https://github.com/facebook/rocksdb/archive/refs/tags/v8.1.1.tar.gz
# URL_HASH MD5=3b4c97ee45df9c8a5517308d31ab008b
get_from_local_if_exists("https://github.com/facebook/rocksdb/archive/refs/tags/v8.1.1.tar.gz")
# URL https://github.com/facebook/rocksdb/archive/refs/tags/v9.7.4.tar.gz
# URL_HASH MD5=204ed2b16eb1850b56d8e91e24ce7c0d
get_from_local_if_exists("https://github.com/facebook/rocksdb/archive/refs/tags/v9.7.4.tar.gz")
ExternalProject_Add(ext_rocksdb
URL ${_url}
URL_HASH MD5=3b4c97ee45df9c8a5517308d31ab008b
URL_HASH MD5=204ed2b16eb1850b56d8e91e24ce7c0d
Comment on lines +1151 to +1156
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider using SHA256 instead of MD5 for the URL_HASH. MD5 is considered cryptographically weak and is prone to collision attacks. Using SHA256 would provide better integrity assurance and maintain consistency with other modern dependencies in this file, such as OpenSSL (line 858) and Azure SDK (line 1421).

# GIT_SHALLOW TRUE
PREFIX "${_base}"
CMAKE_ARGS -DCMAKE_BUILD_TYPE:STRING=${TD_CONFIG_NAME}
Expand Down
Loading