-
Notifications
You must be signed in to change notification settings - Fork 5k
feat(stream): support nested event window sub-events #35149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -50,6 +50,7 @@ def build(self): | |
|
|
||
| # Build make command | ||
| cflags = "-Wall -O2 -pthread" | ||
| asflags = "-Wa,--noexecstack" | ||
| if self.options.get_safe("fPIC"): | ||
| cflags += " -fPIC" | ||
|
|
||
|
|
@@ -59,7 +60,7 @@ def build(self): | |
|
|
||
| # Execute make compilation | ||
| self.run( | ||
| f'make CFLAGS="{cflags}" CC={self.settings.get_safe("compiler", default="gcc")} libfast-lzma2', | ||
| f'make CFLAGS="{cflags}" ASFLAGS="{asflags}" CC={self.settings.get_safe("compiler", default="gcc")} libfast-lzma2', | ||
| cwd=source_folder, | ||
| ) | ||
|
Comment on lines
51
to
65
|
||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ASFLAGS := -Wa,--noexecstackis applied globally.--noexecstackis not universally supported by all assemblers/platforms; applying it unconditionally can break builds on non-ELF targets. Consider conditioning this flag on platforms where it’s supported (e.g., Linux/FreeBSD + GNU as), or appending it only when the assembler is known to accept it.