Add support for the dolphin file manager#2182
Add support for the dolphin file manager#2182BlueDrink9 wants to merge 2 commits intotalonhub:mainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 945410121e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Just a note: |
|
Another note: |
| @@ -0,0 +1,49 @@ | |||
| from talon import Context, Module, actions, clip, ui | |||
There was a problem hiding this comment.
Can you remove the unused imports?
| - | ||
|
|
||
| tag(): user.tabs | ||
| tag(): user.file_manager |
There was a problem hiding this comment.
Should you also activate the user.navigation tag?
|
I was surprised to find that file rename was not already in the file manager tag. I find myself creating a reload or refresh command for quite a lot of applications, comma it definitely seems generally useful outside of just browsers. That being said, it does feel like a nuisance to have a tag for just a single command, but I suppose that's better than making users redefine the command for every application. |
| actions.insert(path) | ||
| actions.key("enter") | ||
|
|
||
| def file_manager_new_folder(name: str = None): |
There was a problem hiding this comment.
Note for backlog session: In some places we do : str = None in Community actions. Should we instead do : Optional[str] = None?
There was a problem hiding this comment.
From the community backlog session — we agree this makes sense, but should be in a separate PR.
nriley
left a comment
nriley
left a comment
There was a problem hiding this comment.
From the Community Backlog session — please address all of @FireChickenProductivity 's issues. Thanks!
| mod = Module() | ||
| mod.apps.dolphin = """ | ||
| os: linux | ||
| and app: dolphin |
There was a problem hiding this comment.
This looks like it could be recursive as you are defining app: dolphin by matching app: dolphin. Whether or not it works, it is confusing to read as in general, we only use app: to refer to apps that are defined with mod.apps. Consider using app.name.
3 participants
No description provided.