Open
Conversation
AndreasArvidsson
requested changes
Jan 24, 2026
Collaborator
AndreasArvidsson
left a comment
AndreasArvidsson
left a comment
There was a problem hiding this comment.
Looks good. When it comes to sorting we feel that everything that is just prose should be sorted alphabetically. Things that logically belonged together like the names of the month and math concepts could be grouped together separately.
Comment on lines
+480
to
+490
| "equal to": "eq", | ||
| "equals": "eq", | ||
| "not equal to": "ne", | ||
| "not equals": "ne", | ||
| "doesnt equal": "ne", | ||
| "less than": "lt", | ||
| "less than or equal to": "le", | ||
| "less equals": "le", | ||
| "greater than": "gt", | ||
| "greater than or equal to": "ge", | ||
| "greater equals": "ge", |
Collaborator
There was a problem hiding this comment.
These looks like something that belongs in programming languages. We can't really see anyone using these abbreviations in the prose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Question: What is
"some": "sum"good for? Is this on the same level as "luv" for "love"? It's conflicting with"start of month": "som", though, and is also available using the command "phones some". Should this be removed?I took the abbreviated mathematical functions from:
I added abbreviations like
eqfor "equals", orltfor "less than", because they can appear in function names.I deliberately didn't sort alphabetically in the third commit and grouped the new abbreviations. This should make review easier. After that: Should I ruthlessly sort everything alphabetically, even though this scatters month names etc.?