cleanup: cimbar_send cli improvement/fix, new emsdk version for wasm build, +++ #159
Merged
cleanup: cimbar_send cli improvement/fix, new emsdk version for wasm build, +++ #159
Conversation
The static helper has it, it should be here too.
https://github.com/chfast/intx/releases/tag/v0.9.3 Newer versions require c++20, but I'm not ready to go there yet.
* removing unused params (ecc and colorbits now folded into config modes) * add back padding around image (for now: a cli arg!) * change default (finally) to mode B Net result: fullscreen will work properly.
sz3
commented
Mar 26, 2026
| xOffset = appCtx->padding / 2; | ||
| } | ||
| glClear(GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT); | ||
| glViewport(xOffset, yOffset, viewportWidth, viewportHeight); |
Owner
Author
There was a problem hiding this comment.
This really is much more complicated now. Oh well!
sz3
commented
Mar 26, 2026
|
|
||
| decltype(auto) operator*() const | ||
| { | ||
| return *_it; |
Owner
Author
There was a problem hiding this comment.
clang wants us to be less magical (or more explicit) with our casts
This was referenced Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cimbar_sendwindow #128) Also, I put the padding back (more closely imitates the web version. This is also how it used to work)