Open
Conversation
Defer events.splice calls and apply them in a single backward merge pass. Also tighten the backward line-ending scan to stop at the list start. Fixes syntax-tree#49 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
added
🤞 phase/open
There was a problem hiding this comment.
Pull request overview
Improves list preprocessing performance by eliminating per-item events.splice() calls in prepareList, reducing complexity from O(n²) to O(n) for large lists.
Changes:
- Defers
listItementer/exit insertions by collecting insertion positions/events during the walk. - Applies all deferred insertions in a single backward merge pass to avoid repeated array shifting.
- Tightens the backward line-ending scan to stop at the current list’s
startindex.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Murderlon
approved these changes
Apr 15, 2026
Member
Murderlon
left a comment
Murderlon
left a comment
There was a problem hiding this comment.
Also no comments from Devin review. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
prepareListcallsevents.splice()twice per list item, making it O(n²). This defers insertions into arrays and applies them in a single backward merge pass, making it O(n). Also tightens the backward line-ending scan to stop atstartinstead of 0.Fixes #49