fix(postgrest): wrap error in PostgrestError instance on processResponse#2240
Open
Vansh1811 wants to merge 1 commit intosupabase:masterfrom
Open
fix(postgrest): wrap error in PostgrestError instance on processResponse#2240Vansh1811 wants to merge 1 commit intosupabase:masterfrom
Vansh1811 wants to merge 1 commit intosupabase:masterfrom
Conversation
Fixes the issue where `error` returned from processResponse is a plain object instead of a PostgrestError instance, breaking `error instanceof PostgrestError` checks. The error field now wraps non-null errors with `new PostgrestError(error)` so consumers can reliably use instanceof checks. Fixes supabase/postgrest-js#1643
Member
I'm unable to find the reference so don't understand the motivation here, please share the full link. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
errorfield returned byprocessResponseinPostgrestBuilderis a plain object literal, not an instance ofPostgrestError. This meanserror instanceof PostgrestErrorchecks always returnfalse, breaking error type-narrowing for consumers.Related issue: supabase/postgrest-js#1643
Fix
Wrap the
errorfield in the final return statement withnew PostgrestError(error)when the error is non-null, so thatinstanceofchecks work correctly.This is consistent with the existing
throw new PostgrestError(error)on line 460 for theshouldThrowOnErrorpath.Testing
Consumers can now reliably narrow the error type: