fix(realtime): throttle connections based on subscription attempts#2236
Open
filipecabaco wants to merge 1 commit intomasterfrom
Open
fix(realtime): throttle connections based on subscription attempts#2236filipecabaco wants to merge 1 commit intomasterfrom
filipecabaco wants to merge 1 commit intomasterfrom
Conversation
@supabase/auth-js
@supabase/functions-js
@supabase/postgrest-js
@supabase/realtime-js
@supabase/storage-js
@supabase/supabase-js
commit: |
8bfa170 to
4e6fa66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 Description
throttle connections based on subscription attempts
What changed?
added a throttling mechanism using a buffer for servers and local storage for browser where we throttle subscriptions to prevent useEffect load and errors.
Why was this change needed?
currently we see users reaching easily the limits of their accounts due to what are potentially errors when it comes to disconnecting and unsubscribing channels and, by consequence, kill the websocket.
this usually happens due to bad useEffect practices.
📋 Checklist
<type>(<scope>): <description>npx nx formatto ensure consistent code formatting