Fix/rpc no params react native#2017
Open
dev-hari-prasad wants to merge 3 commits intosupabase:masterfrom
Open
Conversation
…ON body Refactors PostgrestBuilder to serialize headers as a plain object instead of a Headers instance, ensuring compatibility with environments expecting plain objects. Also ensures that requests without a body send an empty JSON object for non-GET/HEAD methods. Adds tests to verify header serialization and correct body handling.
Author
|
@mandarini @avallete Pls check |
Contributor
|
This PR has been marked as stale because it has not had activity for 90 days. Please rebase and update if this is still needed. |
mandarini
requested changes
Apr 20, 2026
Contributor
mandarini
left a comment
mandarini
left a comment
There was a problem hiding this comment.
@dev-hari-prasad can you please rebase and resolve conflicts, and remove changes to the .husky dir?
Author
Sure, give me a day or two, I will do the required and rebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 Description
This PR improves request handling in the PostgREST client to make it more compatible with custom
fetchimplementations and fixes Husky hooks to avoid reliance on globally installed binaries.What changed?
PostgREST client improvements
PostgrestBuilder.tsto serialize request headers as a plain object instead of aHeadersinstance. This avoids compatibility issues with non-standard or customfetchimplementations.{}) instead ofundefined. This fixes edge cases like RPC calls without parameters.headers_serialization.test.tsto verify:{}as the request body.Husky hook updates
.husky/commit-msgand.husky/pre-pushto use local binaries (./node_modules/.bin/...) instead ofnpx.Why was this change needed?
fetchsetups) do not fully support theHeadersAPI, causing requests to fail unexpectedly.npxinside Husky hooks can break in CI or restricted environments where global binaries are unavailable.Closes #1562 (if applicable)
📸 Screenshots / Examples
N/A – changes are covered by tests.
🔄 Breaking changes
📋 Checklist
<type>(<scope>): <description>npx nx formatto ensure consistent code formattingThis PR fixes #1562