Skip plugin install and upgrade if the requested version is already installed#1552
Open
vcheung-stripe wants to merge 4 commits intomasterfrom
Open
Skip plugin install and upgrade if the requested version is already installed#1552vcheung-stripe wants to merge 4 commits intomasterfrom
vcheung-stripe wants to merge 4 commits intomasterfrom
Conversation
… upgrade When the user requests the latest plugin version (no version specified for install, or any upgrade), the "already installed" message now appends "(latest)" to clarify that the installed version is up to date. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Committed-By-Agent: claude
Removes the helper method to avoid multiple return values, mirroring the structure of upgrade.go. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Committed-By-Agent: claude
…essages Adds InstalledVersion() to Plugin and uses it to display the prior version when upgrading, e.g. "upgraded from v1.0.0 to v1.1.0". Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Committed-By-Agent: claude
…grade Factors out versionChangeVerb helper using hashicorp/go-version to pick the correct verb when showing version transition messages. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Committed-By-Agent: claude
vcheung-stripe
commented
Apr 17, 2026
| return plugin, version | ||
| } | ||
|
|
||
| func (ic *InstallCmd) installPluginByName(cmd *cobra.Command, arg string) (version string, err error) { |
Collaborator
Author
There was a problem hiding this comment.
This looks like a big change but most of it is from inlining installPluginByName.
vcheung-stripe
commented
Apr 17, 2026
| return nil | ||
| } | ||
|
|
||
| // IsVersionInstalled returns true if the given version of the plugin is already installed on disk. |
Collaborator
Author
There was a problem hiding this comment.
I think checking the file system has the expected paths and files is enough to say that a version is installed. We could validate the plugin checksum if we want to make this even more precise, but this feels good enough for now since this feature is more of a nicety.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What it says on the tin. I also updated these commands to output what version was previously installed, if there was one.
Manually tested a bunch of situations: