Skip to content

fix: address findings from 2026-04-21 commit-review window#11694

Draft
Planeshifter wants to merge 4 commits intodevelopfrom
philipp/fix-commit-review-2026-04-21
Draft

fix: address findings from 2026-04-21 commit-review window#11694
Planeshifter wants to merge 4 commits intodevelopfrom
philipp/fix-commit-review-2026-04-21

Conversation

@Planeshifter
Copy link
Copy Markdown
Member

Description

Follow-up fixes for commits merged to develop between 7a025ca7 (2026-04-20 16:07:19 -0400) and 1089250d (2026-04-21 03:37:01 -0700) — 49 first-parent commits in the window. Fixes are grouped by package, one commit per group.

blas/base/cgemv (originating commit b3e5d1b5)

  • Bug: when beta == 0, the y = beta*y short-circuit fills y with alpha instead of zero, producing alpha + alpha*A*x per element whenever alpha != 0. Mirror the dgemv/sgemv pattern by passing new Complex64( 0.0, 0.0 ) to cfill so prior NaN values do not propagate (lib/base.js L145–150).
  • Style: restore symmetric spacing around * in the byte-stride calculations sa1 = strideA1 * 2 / sa2 = strideA2 * 2 (lib/base.js L163–164).
  • Style: add the missing // MAIN // section banner before the function JSDoc (lib/ndarray.js L25–28).

blas/ext/base/ddiff (originating commit a0816279)

  • Docs: README intro to the strided example was missing the verb — to differences of every other element:to compute differences of every other element: (README.md L71).

stats/base/ndarray/dmaxsorted (originating commit 66e748fe)

  • Docs: the first two lines inside int main() of the C example used 4-space indentation while the rest of the body uses 3 spaces — re-indent for consistency with sibling dmeanwd/dmeanpn/dmeanpw READMEs (README.md L192–193).

napi/argv-booleanarray (originating commit e60e084f)

  • Docs: e60e084f changed @returns to Uint8Array, but the wrapper still returns the original BooleanArray v; only the reinterpreted view is passed to the addon. Revert the annotation to BooleanArray to match the actual return value and the @param (lib/native.js L34–35).

Related Issues

This pull request has the following related issues:

  • None.

Questions

No.

Other

Validation

  • Style guide compliance audit across blas/**, ndarray/**, napi/**, stats/**, math/**, _tools/eslint/**, READMEs touched by 59d0640a.
  • Bug scan across the union diff plus per-commit diffs.
  • Each finding was independently re-verified against the worktree before applying a fix.

Excluded

Checklist

AI Assistance

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was authored by Claude Code as part of an automated commit-review pass over the prior 24 hours of develop. Each finding was generated by parallel reviewer agents, filtered for high-signal-only issues (objective bugs, unambiguous style-guide violations, on-sight typos), and independently re-verified against the worktree before any fix was applied. A maintainer should audit before promoting from draft.


@stdlib-js/reviewers

claude added 4 commits April 21, 2026 12:52
The `beta == 0` short-circuit incorrectly filled `y` with `alpha` instead of zero, producing `alpha + alpha*A*x` per element instead of `alpha*A*x` whenever `alpha != 0`. Mirror the sibling `dgemv`/`sgemv` pattern by filling with a complex zero. Also restore symmetric spacing around `*` in the `strideA1`/`strideA2` byte-stride calculations and add the missing `// MAIN //` section banner in `lib/ndarray.js`.
Restore the missing verb in the strided-array example introductory line so it reads "to compute differences of every other element".
…xample

The first two lines inside `int main()` used 4-space indentation while the rest of the body uses 3 spaces. Re-indent for consistency with siblings (`dmeanwd`, `dmeanpn`, `dmeanpw`).
The wrapper returns the original `BooleanArray` input, but the JSDoc was changed to claim a `Uint8Array` return. Match the `@param` type and the actual return value.
@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Apr 21, 2026
@Planeshifter Planeshifter changed the title Follow-up fixes for 2026-04-21 commit-review window fix: address findings from 2026-04-21 commit-review window Apr 21, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/base/cgemv $\color{green}588/588$
$\color{green}+100.00%$
$\color{green}80/80$
$\color{green}+100.00%$
$\color{green}4/4$
$\color{green}+100.00%$
$\color{green}588/588$
$\color{green}+100.00%$
blas/ext/base/ddiff $\color{red}627/629$
$\color{green}+99.68%$
$\color{red}44/45$
$\color{green}+97.78%$
$\color{green}5/5$
$\color{green}+100.00%$
$\color{red}627/629$
$\color{green}+99.68%$
napi/argv-booleanarray $\color{green}156/156$
$\color{green}+100.00%$
$\color{green}8/8$
$\color{green}+100.00%$
$\color{green}1/1$
$\color{green}+100.00%$
$\color{green}156/156$
$\color{green}+100.00%$
stats/base/ndarray/dmaxsorted $\color{green}170/170$
$\color{green}+100.00%$
$\color{green}7/7$
$\color{green}+100.00%$
$\color{green}2/2$
$\color{green}+100.00%$
$\color{green}170/170$
$\color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants