bench: fix swapped dtypes in size benchmarks#11648
Merged
Conversation
…arks
The per-size float32 and float64 benchmark files had their `opts.dtype`
values swapped relative to the filename and bench label, so each file
benchmarked the opposite dtype from the one it advertised.
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
ndarray/{ones,zeros,empty} size benchmarks
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
opts.dtypevalues in the per-sizefloat32andfloat64benchmark files for@stdlib/ndarray/ones,@stdlib/ndarray/zeros, and@stdlib/ndarray/empty. The values were swapped between the two files in each package, so each file benchmarked the opposite dtype from the one its filename and bench label advertised.Related Issues
No.
Questions
No.
Other
Scope verified across all ndarray benchmark files: only the three packages above use the
opts.dtypepattern. The*-likeandndarray/base/*size benchmarks pass the dtype positionally (e.g., `zeros( 'float32', [len], 'row-major' )`) and were already correct.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
Claude Code identified the swapped dtypes while reviewing
@stdlib/ndarray/onesand applied the fix to all affected packages per my instructions.@stdlib-js/reviewers