Skip to content

[6.x] Improve send password reset modal#12577

Merged
jackmcdade merged 2 commits intomasterfrom
improve-send-password-reset-modal
Sep 25, 2025
Merged

[6.x] Improve send password reset modal#12577
jackmcdade merged 2 commits intomasterfrom
improve-send-password-reset-modal

Conversation

@jaygeorge
Copy link
Copy Markdown
Contributor

This should close #12536, making the modal look less repetitive—both visually and content-wise.

I did notice that it looks worse in dark mode because of some heavy shadowing but that's a separate "dark mode" issue that we'll tackle later

@jackmcdade jackmcdade merged commit 035a2ff into master Sep 25, 2025
19 checks passed
@jackmcdade jackmcdade deleted the improve-send-password-reset-modal branch September 25, 2025 11:48
@ebeauchamps
Copy link
Copy Markdown
Contributor

ebeauchamps commented Sep 25, 2025

@jaygeorge Hello. I still have "Send password reset email to this user?" in the modal on alpha9 and not the new "Would you like to email a reset link to this user?", therefore I get the English string and not the French one when displaying the CP in French.

Has this been commited after the alpha9 release?

@jackmcdade
Copy link
Copy Markdown
Member

@ebeauchamps the French translation string will need to be updated.

@ebeauchamps
Copy link
Copy Markdown
Contributor

Hello @jackmcdade

It appears to me that in this commit 27acc3d the English key was changed to "Would you like...." and the French translation was copied from the previous "Send password..." But in Alpha 9 the string is "Send password...", which has been removed from the French file, so the key is displayed in English not French.

The translator is not finding "Send password.." anymore.

I hope it makes sense.

@ebeauchamps
Copy link
Copy Markdown
Contributor

@jackmcdade @jaygeorge My bad: this PR is not included in alpha9. Please forgive me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants