[6.x] Improve send password reset modal#12577
Conversation
…ly differentiate it from the heading
|
@jaygeorge Hello. I still have "Send password reset email to this user?" in the modal on alpha9 and not the new "Would you like to email a reset link to this user?", therefore I get the English string and not the French one when displaying the CP in French. Has this been commited after the alpha9 release? |
|
@ebeauchamps the French translation string will need to be updated. |
|
Hello @jackmcdade It appears to me that in this commit 27acc3d the English key was changed to "Would you like...." and the French translation was copied from the previous "Send password..." But in Alpha 9 the string is "Send password...", which has been removed from the French file, so the key is displayed in English not French. The translator is not finding "Send password.." anymore. I hope it makes sense. |
|
@jackmcdade @jaygeorge My bad: this PR is not included in alpha9. Please forgive me. |
This should close #12536, making the modal look less repetitive—both visually and content-wise.
I did notice that it looks worse in dark mode because of some heavy shadowing but that's a separate "dark mode" issue that we'll tackle later