Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #473 +/- ##
==========================================
- Coverage 71.44% 71.40% -0.04%
==========================================
Files 353 354 +1
Lines 14332 14333 +1
Branches 1209 1209
==========================================
- Hits 10239 10235 -4
- Misses 3697 3700 +3
- Partials 396 398 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| { | ||
| public required string type { get; set; } | ||
|
|
||
| public required string units { get; set; } |
There was a problem hiding this comment.
I'm not an amazing happy that we have units both on the DataObject and the geometry...
but we appear to do this pattern for other DataObjects (revit, civil etc..)... so we should continue.
Units in Speckle have always suffered from excessive and ambiguous redundancy.
There was a problem hiding this comment.
I'm not expecting a response, I'm just grumbling 😁
|
|
||
| public interface IRhinoObject : IDataObject | ||
| { | ||
| string type { get; } |
There was a problem hiding this comment.
why not include RawEncoding and units here?
just curious?
2 participants
Rhino connector was sending raw geometry directly into collections. This PR is creating the RhinoObject to align Rhino with other connectors.
The rawEncoding field holds the native 3dm blob so Breps/Extrusions/SubDs can roundtrip back to their original form on receive, while displayValue carries mesh primitives for the viewer.
Related connectors PR: specklesystems/speckle-sharp-connectors#1371