Close response body streams after processing#503
Merged
freekmurze merged 1 commit intomainfrom Mar 20, 2026
Merged
Conversation
…or leaks When using StreamHandler with stream mode enabled, response body streams that are not explicitly closed keep their underlying file descriptors open. Over a large crawl (1000+ URLs), this can exhaust the OS file descriptor limit and cause subsequent requests to fail with connection errors. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CrawlRequestFulfilledafter processing each URLStreamHandlerwith stream mode, unclosed response bodies keep file descriptors open. Over a large crawl (1000+ URLs), this exhausts the OS file descriptor limit and causes subsequent requests to fail with connection errorsfinallyblock ensures streams are closed even if an exception occurs during processingCrawlResponse::body()which uses the cached string that was read before the stream is closed