Skip to content

fix: assets via memory block#1026

Merged
maciejmakowski2003 merged 4 commits intomainfrom
fix/android-release-asset-resolution
Apr 16, 2026
Merged

fix: assets via memory block#1026
maciejmakowski2003 merged 4 commits intomainfrom
fix/android-release-asset-resolution

Conversation

@mdydek
Copy link
Copy Markdown
Collaborator

@mdydek mdydek commented Apr 16, 2026

Closes #

⚠️ Breaking changes ⚠️

Introduced changes

  • in this implementation assets are decoded as memory block in android release mode, because resolveAssetSource works differently in android release mode
  • AudioFileSourceNode now uses correct channel count

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added/Conducted relevant tests
  • Performed self-review of the code
  • Updated Web Audio API coverage
  • Added support for web
  • Updated old arch android spec file

@mdydek mdydek added the fix label Apr 16, 2026
Copy link
Copy Markdown
Contributor

@closetcaiman closetcaiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread packages/react-native-audio-api/src/core/AudioDecoder.ts Outdated
@maciejmakowski2003 maciejmakowski2003 merged commit bf5b124 into main Apr 16, 2026
5 checks passed
@mdydek mdydek deleted the fix/android-release-asset-resolution branch April 20, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants