[c++/python/r] Pushdown SOMA object management to C++#4436
Open
XanthosXanthopoulos wants to merge 33 commits intomainfrom
Open
[c++/python/r] Pushdown SOMA object management to C++#4436XanthosXanthopoulos wants to merge 33 commits intomainfrom
XanthosXanthopoulos wants to merge 33 commits intomainfrom
Conversation
Tie metadata lifetime with C++ handle
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4436 +/- ##
==========================================
- Coverage 85.27% 84.90% -0.37%
==========================================
Files 136 136
Lines 21263 21344 +81
==========================================
- Hits 18132 18123 -9
- Misses 3131 3221 +90
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Collaborator
|
The CI should be fixed by a rebase or merge on main. |
jp-dark
reviewed
Apr 17, 2026
Collaborator
jp-dark
left a comment
There was a problem hiding this comment.
I haven't finished reviewing this yet, but so far it is looking good. I have a couple small comments. As discussed offline, I'd also like to see some unit tests directly on the new metadata class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: Push SOMA object lifetime management to C++
Changes:
This PR introduces the following changes:
SOMACollectioncaches handles to its member when first accessed. These handles are now used to construct the Python and R wrapper objects to avoid reopening or implementing the caching in the API side.closemethod now accepts an optional argument to define whether members of a group should be closed once a group is closed.SOMAObjectnow does not recreate the C++ handle but rather it reinitialized the same handle (but can and will make member objects invalid)Notes for Reviewer:
The R devel error is not related to these changes.