Skip to content

chore(docker): add packages/utils to app and realtime Dockerfiles#4229

Merged
waleedlatif1 merged 2 commits intostagingfrom
feat/docker
Apr 19, 2026
Merged

chore(docker): add packages/utils to app and realtime Dockerfiles#4229
waleedlatif1 merged 2 commits intostagingfrom
feat/docker

Conversation

@waleedlatif1
Copy link
Copy Markdown
Collaborator

Summary

Type of Change

  • Bug fix

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment Apr 19, 2026 0:55am

Request Review

@cursor
Copy link
Copy Markdown

cursor bot commented Apr 19, 2026

PR Summary

Low Risk
Low risk: Docker build changes only, adding a missing workspace package to fix dependency resolution; main risk is minor image size/cache impact or a path/copy mismatch causing build failures.

Overview
Fixes Docker builds after extracting @sim/utils into a workspace package by ensuring packages/utils is present during dependency install/build.

Updates app.Dockerfile and realtime.Dockerfile to create the packages/utils directory and copy its package.json into deps/builder stages, and adds a runner-stage copy of packages/utils for the realtime image so runtime workspace deps are available.

Reviewed by Cursor Bugbot for commit add1ac0. Configure here.

Comment thread docker/realtime.Dockerfile
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Apr 19, 2026

Greptile Summary

This PR adds packages/utils to the deps and builder stages of both app.Dockerfile and realtime.Dockerfile, following the extraction of @sim/utils as a workspace package in #4228. Without the directory and package.json present during bun install, dependency resolution would fail. The realtime.Dockerfile also correctly copies the full packages/utils source to the runner stage, since the socket server runs via bun directly rather than through a Next.js standalone bundle.

Confidence Score: 5/5

Safe to merge — minimal, targeted fix with correct handling in both Dockerfiles

The change is a straightforward follow-up to a workspace package extraction. Both Dockerfiles are updated consistently: deps and builder stages get the package.json copies needed for bun workspace resolution, and the realtime runner stage gets the full source copy required for direct bun execution. The app runner stage correctly omits the explicit copy because Next.js standalone bundling handles it.

No files require special attention

Important Files Changed

Filename Overview
docker/app.Dockerfile Adds packages/utils to deps mkdir, deps COPY, and builder COPY stages; runner stage correctly relies on Next.js standalone output which bundles utils automatically
docker/realtime.Dockerfile Adds packages/utils to deps mkdir, deps COPY, builder COPY, and runner COPY stages; runner copy is necessary since the socket server runs via bun directly rather than a standalone bundle

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    subgraph app.Dockerfile
        A1[base] --> A2[deps\nmkdir packages/utils\nCOPY packages/utils/package.json\nbun install]
        A2 --> A3[builder\nCOPY packages/utils/package.json\nCOPY packages/...\nbun run build]
        A3 --> A4[runner\nNext.js standalone\nautomatically bundles utils]
    end

    subgraph realtime.Dockerfile
        B1[base] --> B2[deps\nmkdir packages/utils\nCOPY packages/utils/package.json\nbun install]
        B2 --> B3[builder\nCOPY packages/utils/package.json\nCOPY packages/...\nno compile step]
        B3 --> B4[runner\nCOPY packages/utils\nbun socket/index.ts]
    end
Loading

Reviews (2): Last reviewed commit: "chore(docker): copy packages/utils in re..." | Re-trigger Greptile

@waleedlatif1
Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1
Copy link
Copy Markdown
Collaborator Author

@cursor review

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit add1ac0. Configure here.

@waleedlatif1 waleedlatif1 merged commit f91c1b6 into staging Apr 19, 2026
14 checks passed
@waleedlatif1 waleedlatif1 deleted the feat/docker branch April 19, 2026 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant