Skip to content

In --default-deny mode, show public icons instead of private icons#2657

Open
RamiNoodle733 wants to merge 1 commit intosimonw:mainfrom
RamiNoodle733:fix/issue-2620
Open

In --default-deny mode, show public icons instead of private icons#2657
RamiNoodle733 wants to merge 1 commit intosimonw:mainfrom
RamiNoodle733:fix/issue-2620

Conversation

@RamiNoodle733
Copy link
Copy Markdown

@RamiNoodle733 RamiNoodle733 commented Mar 8, 2026

Fixes #2620

Summary

  • pass default_deny into template context
  • update page templates to invert icon semantics in --default-deny mode:
    • show 🌐 for public resources
    • do not show 🔒 for private resources
  • retain existing 🔒 behavior when not in --default-deny mode
  • add a regression test for database table icons in default-deny mode

Tests

  • uv run pytest -q tests/test_default_deny.py
  • uv run ruff check datasette/app.py tests/test_default_deny.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In --default-deny mode show icons for public, not private tables

1 participant