feat(theme): update classic theme styles and fix hover/active#2511
feat(theme): update classic theme styles and fix hover/active#2511danielleroux wants to merge 1 commit intomainfrom
Conversation
…for buttons, chips, links, and switches
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the classic theme by fixing hover and active states for buttons, chips, links, and invalid switches, while also aligning theme variable application with data-attribute selectors. The review feedback identifies that the removal of body class selectors is a breaking change, necessitating a major version bump in the changeset and a corresponding update to the PR title. Furthermore, the reviewer pointed out that manual modifications to auto-generated SCSS files should be moved to the source definitions to prevent them from being overwritten.
| --- | ||
| '@siemens/ix': patch | ||
| --- | ||
|
|
||
| Fix classic theme hover and active states for buttons, chips, links, and invalid switches, and align classic light and dark variable application with the supported data-attribute theme selectors. |
There was a problem hiding this comment.
The removal of the body class selectors in the theme index files is a breaking change. According to the Repository Style Guide (Rule 39), major changes must be clearly described in the changeset with migration steps. Additionally, the PR title should be updated to include a ! (e.g., feat(theme)!) to signal the breaking change (Rule 16). Finally, please ensure visual regression tests are updated as they are currently unchecked in the PR description (Rule 59).
| --- | |
| '@siemens/ix': patch | |
| --- | |
| Fix classic theme hover and active states for buttons, chips, links, and invalid switches, and align classic light and dark variable application with the supported data-attribute theme selectors. | |
| --- | |
| '@siemens/ix': major | |
| --- | |
| Fix classic theme hover and active states for buttons, chips, links, and invalid switches. | |
| ### Breaking Change | |
| The body[class*="theme-classic-dark"] and body[class*="theme-classic-light"] selectors have been removed. Use the data-attribute selectors [data-ix-theme="classic"][data-ix-color-schema="dark|light"] instead. |
References
- If the change is major, ensure that the changeset summary clearly describes the breaking nature of the change and the migration steps consumers need. (link)
| --theme-color-neutral-40: rgba(182, 184, 185, 0.4); | ||
| --theme-color-primary: #00bde3; | ||
| --theme-color-primary--active: #00eaff; | ||
| --theme-color-primary--active: #00d3e5; |
There was a problem hiding this comment.
This file is marked as auto-generated. Manual edits will be overwritten by the build process. Please ensure these token updates are made in the source definitions and propagated via the generation script. This applies to all SCSS files modified in this PR. Note that new properties should also include @SInCE tags in the source to comply with Rule 67.
1 participant
💡 What is the current behavior?
Jira: [IX-4197]
🆕 What is the new behavior?
Update to latest design tokens
🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm test)pnpm lint)pnpm build, changes pushed)👨💻 Help & support