fix(core/chip|pill): update padding and colors#2502
fix(core/chip|pill): update padding and colors#2502nuke-ellington wants to merge 4 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 5146cf8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the chip component to use specific design tokens for hover and active states on filled status chips, replacing the previous semi-transparent overlay method. It also simplifies and standardizes padding across various chip variants while retaining the overlay approach for custom-colored chips. Feedback was provided regarding an inconsistency in the right padding for outline chips that could cause visual regressions, along with a reminder to update the pull request description and include the mandatory IX issue reference as required by the style guide.
|
2 participants
💡 What is the current behavior?
GitHub Issue Number: #
🆕 What is the new behavior?
Fix hover and active background colors of filled status chips (alarm, critical, warning, info, neutral, success) to use the correct design tokens (
--theme-color-*--hover/--theme-color-*--active) instead of a semi-transparent black overlay, aligning the rendered result with the Figma specification. Custom color chips retain the overlay approach. Chip padding is also corrected to be uniform across icon and non-icon variants.🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm test)pnpm lint)pnpm build, changes pushed)👨💻 Help & support