Implemented Leaderboards, more Achievements features and some Snapshots features (saved games)#6
Open
fbricker wants to merge 13 commits intoshokimble:masterfrom
Open
Implemented Leaderboards, more Achievements features and some Snapshots features (saved games)#6fbricker wants to merge 13 commits intoshokimble:masterfrom
fbricker wants to merge 13 commits intoshokimble:masterfrom
Conversation
Owner
|
Hey, Just reviewing the PR. Is there a reason why Google drive write permissions are required? Can you point me to the docs where it says so. I'm just wary of adding unnecessary scope requests that a user may not be comfortable with. Otherwise it looks good. |
… granted access to Saved Games
Added method to get player ID
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, thanks for your work!
It'll be nice if you can merge this and send it to node repositories. I've tested it and updated the documentation 😄
Thanks!