fix: restore scroll position when RTL component preview mounts#10434
Open
arifwp wants to merge 1 commit intoshadcn-ui:mainfrom
Open
fix: restore scroll position when RTL component preview mounts#10434arifwp wants to merge 1 commit intoshadcn-ui:mainfrom
arifwp wants to merge 1 commit intoshadcn-ui:mainfrom
Conversation
Contributor
|
@arifwp is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the auto-scroll behavior on the Command component docs page when navigating to:
/docs/components/radix/command/docs/components/base/commandRoot Cause
The RTL
ComponentPreviewrenders aLanguageSelectorwhich uses Base UI'sSelectcomponent. Base UI Select internally renders a hidden input that receives focus on mount, causing the browser to scroll to its position (~4435px down the page).Fix
Capture
window.scrollYbefore the RTL component mounts, then restore it after mount viarequestAnimationFrame.How to test
/docs/components/radix/commandCloses #10394