fix: avoid re-render in useMobile#10433
Open
iloveitaly wants to merge 2 commits intoshadcn-ui:mainfrom
Open
Conversation
Contributor
|
@iloveitaly is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
|
I ran into the same issue while running eslint and got the import { useSyncExternalStore } from "react";
export function useIsMobile(mobileBreakpoint = 768) {
return useSyncExternalStore(
(callback) => {
const mql = globalThis.matchMedia(
`(max-width: ${(mobileBreakpoint - 1).toFixed(0)}px)`,
);
mql.addEventListener("change", callback);
return () => {
mql.removeEventListener("change", callback);
};
},
() => window.innerWidth < mobileBreakpoint, // Client value
() => false, // Server/Initial hydration value
);
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves a React warning triggered by the
useIsMobilehook:Warning: Calling setState synchronously within an effect can trigger cascading renders.This was added with a recent linting update.
Currently, the hook initializes state as
undefinedand then synchronously callssetIsMobileon the first pass of theuseEffect.This forces React to immediately re-render the component after the initial paint, which can cause layout shifts and degrade performance.
Changes Made
useStateinitialization to lazily evaluatewindow.innerWidthso the correct boolean is set immediately on the first render.typeof window !== "undefined"check during state initialization to ensure it remains SSR-safe.setIsMobilecall from within theuseEffectbody. The initial state now handles the first render correctly, and the effect strictly acts as an event listener for subsequent window resizing.