Skip to content

fix(sidebar): use semantic border color token#10420

Open
NBN7 wants to merge 1 commit intoshadcn-ui:mainfrom
NBN7:fix/sidebar-border-color
Open

fix(sidebar): use semantic border color token#10420
NBN7 wants to merge 1 commit intoshadcn-ui:mainfrom
NBN7:fix/sidebar-border-color

Conversation

@NBN7
Copy link
Copy Markdown

@NBN7 NBN7 commented Apr 16, 2026

Why this change matters

This update ensures that the sidebar border uses the design system’s semantic color token instead of relying on implicit or default border colors.

Previously, the component only defined border placement (border-r, border-l) without explicitly setting the border color. This made the final appearance dependent on inherited styles or browser defaults, which can lead to inconsistencies across themes (especially when using CSS variables for theming).

By adding border-sidebar-border, we:

  • Align with the design system: The sidebar now consistently uses the intended --sidebar-border token.
  • Improve theme accuracy: Colors update correctly when switching or customizing themes (e.g., via CSS variables like --sidebar-border).
  • Avoid implicit styling: Removes reliance on fallback or inherited border colors, making the component more predictable.
  • Ensure visual consistency: Matches other components that already rely on semantic border tokens.

In short, this change makes the component fully theme-aware and consistent with the rest of the system.

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Apr 16, 2026

@AVTNacho is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@NBN7 NBN7 force-pushed the fix/sidebar-border-color branch from 1cb8726 to 62da7c5 Compare April 16, 2026 21:20
@NBN7 NBN7 force-pushed the fix/sidebar-border-color branch from 62da7c5 to 3075d58 Compare April 16, 2026 21:28
@NBN7 NBN7 changed the title Sidebar border fix(sidebar): use semantic border color token Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant