fix(sidebar): use semantic border color token#10420
Open
NBN7 wants to merge 1 commit intoshadcn-ui:mainfrom
Open
fix(sidebar): use semantic border color token#10420NBN7 wants to merge 1 commit intoshadcn-ui:mainfrom
NBN7 wants to merge 1 commit intoshadcn-ui:mainfrom
Conversation
Contributor
|
@AVTNacho is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
1cb8726 to
62da7c5
Compare
62da7c5 to
3075d58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this change matters
This update ensures that the sidebar border uses the design system’s semantic color token instead of relying on implicit or default border colors.
Previously, the component only defined border placement (
border-r,border-l) without explicitly setting the border color. This made the final appearance dependent on inherited styles or browser defaults, which can lead to inconsistencies across themes (especially when using CSS variables for theming).By adding
border-sidebar-border, we:--sidebar-bordertoken.--sidebar-border).In short, this change makes the component fully theme-aware and consistent with the rest of the system.