fix(a11y): add aria-label to data table filter inputs (#10397)#10402
Open
cloudyun888 wants to merge 3 commits intoshadcn-ui:mainfrom
Open
fix(a11y): add aria-label to data table filter inputs (#10397)#10402cloudyun888 wants to merge 3 commits intoshadcn-ui:mainfrom
cloudyun888 wants to merge 3 commits intoshadcn-ui:mainfrom
Conversation
Add aria-label="Filter emails" to the filter Input to comply with WCAG 2.1 Level A (4.1.2 Name, Role, Value). Placeholder alone is not a valid accessible name. Fixes shadcn-ui#10397
Add aria-label="Filter emails" to the filter Input to comply with WCAG 2.1 Level A (4.1.2 Name, Role, Value). Placeholder alone is not a valid accessible name. Fixes shadcn-ui#10397
Add aria-label="Filter tasks" to the filter Input to comply with WCAG 2.1 Level A (4.1.2 Name, Role, Value). Placeholder alone is not a valid accessible name. Fixes shadcn-ui#10397
Contributor
|
@cloudyun888 is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
aria-labelto data table filter<Input>components across all example variants(Radix, Base, and Tasks) to comply with WCAG 2.1 Level A (4.1.2 Name, Role, Value).
Placeholder text alone is not a valid accessible name. Screen readers would announce
"edit text" with no context that this is a filter control.
Changes
apps/v4/examples/radix/data-table-demo.tsx"Filter emails"apps/v4/examples/base/data-table-demo.tsx"Filter emails"apps/v4/app/(app)/examples/tasks/components/data-table-toolbar.tsx"Filter tasks"Testing
aria-labelis presentFixes #10397