Change to use stream.ToArray

[andrew-welker]

According to issue sindresorhus/get-stream#50, there are issues with using get-stream when using node versions

= 18.14.0 and >=19.5.0. The method now used is taken directly
from the get-stream readme, and makes sense in this relatively simple scenario.

Should close #459

[andrew-welker]

Looks like I need to update/modify a test? I'm not that familiar with ava as a testing framework. One of the tests is throwing an exception: stream.toArray is not a function, and I'm guessing it's because of the writerDouble in the test. Any help or insight is appreciated.

[travi]

pulling in some of the related details:

• sounds like this was a bug in node: stream: fix pipeline callback not called on ended stream nodejs/node#46600
• the node bug was fixed in v18.16.0 and v19.8.0

[travi]

thanks for the investigation and PR suggestion, @andrew-welker!

given that this was a bug in node that has since been fixed, and not a problem with get-stream or our use of it, i'm wondering if it is truly worth us changing our usage here specifically related to #459 vs simply recommending updating to the latest node versions as the proper fix.

are there details that i'm overlooking that would require this update if using the fixed node versions?

[bradennapier]

I am using node 20 and still have the issue as mentioned in #459