#4893 Async inventory review fixes#5651
Open
marchcat wants to merge 7 commits intopepper/async-inventoryfrom
Open
#4893 Async inventory review fixes#5651marchcat wants to merge 7 commits intopepper/async-inventoryfrom
marchcat wants to merge 7 commits intopepper/async-inventoryfrom
Conversation
…llbacks on early exit
…ndle duplicate names
… tracking semantics
… widgets are created
akleshchev
reviewed
Apr 15, 2026
akleshchev
requested changes
Apr 16, 2026
Contributor
akleshchev
left a comment
akleshchev
left a comment
There was a problem hiding this comment.
Spam, example:
2026-04-16T19:58:46Z WARNING #Inventory# newview/llinventorymodel.cpp(5039) LLInventoryModel::validate : invalid desc count for ae5834b2-7d47-6557-0cff-f7e05c763801 [/My Inventory/Objects/tmp7] cached 341 expected 1+5=6
That's a massive discrepancy between cached and expected, and it's reported each run, should it even complain if inventory isn't loaded?
P.S. Please make sure to test this with Inventory2 Tester and check marketplace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added destructor to clean up callbacks and connection if loading is interrupted.
Fixed mChildNameCache to avoid removing wrong pointers when siblings share names.
Restored singleton initialization flow to preserve dependency tracking.
Ensured system folders are created at startup while keeping lazy loading for subfolders.