fix: add missing GITHUB_TOKEN default#120
Draft
pandektes-braedon wants to merge 2 commits intoscaleway:mainfrom
Draft
fix: add missing GITHUB_TOKEN default#120pandektes-braedon wants to merge 2 commits intoscaleway:mainfrom
pandektes-braedon wants to merge 2 commits intoscaleway:mainfrom
Conversation
Author
There was a problem hiding this comment.
Is there a reason there is no lockfile? Should I remove this from the PR?
Member
There was a problem hiding this comment.
Are you referring to https://github.com/scaleway/action-scw/blob/master/pnpm-lock.yaml ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This is WIP and I still need to test this PR works as expected.
Description
Fixed GitHub API rate limiting issues by ensuring the repo-token is used during CLI binary downloads and providing a default value for the token.
Reason for Change
The action was failing with HttpClientError: API rate limit exceeded because it was making unauthenticated requests to GitHub Releases when downloading the Scaleway CLI binary.
While the action previously supported a repo-token for version checks, it wasn't being passed to the tool-cache download utility, and it wasn't provided by default. This PR:
These changes ensure that all requests to the GitHub API are authenticated, increasing the rate limit from 60 to 1,000+ requests per hour per repository.