Skip to content

Improve insertnode#853

Draft
samclarke wants to merge 2 commits intomasterfrom
improve-insertnode
Draft

Improve insertnode#853
samclarke wants to merge 2 commits intomasterfrom
improve-insertnode

Conversation

@samclarke
Copy link
Copy Markdown
Owner

Will move inserted inline nodes at the start of end or the input into the start/end containers.

For example, Inserting:

<em>foo</em>

into:

<b>|text</b><u>text|</u>

will now become:

<b><em>foo</em></b>

instead of what it currently becomes:

<em>foo</em>

Normalises node first as innerText will add extra line breaks otherwise.
Fixes #839
Will move inserted inline nodes at the start of end or the input into
the start/end containers.

For example, Inserting:
"<em>foo</em>"
into:
"<b>|text</b><u>text|</u>"
will become:
"<b><em>foo</em></b>"
and not:
"<em>foo</em>"
@samclarke samclarke removed the plugins label Oct 14, 2021
@samclarke samclarke added this to the v3.2.0 milestone Oct 14, 2021
@samclarke samclarke modified the milestones: v3.2.0, v3.3.0 Mar 4, 2023
@live627
Copy link
Copy Markdown
Collaborator

live627 commented Aug 26, 2023

How would I test this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants