Feature/portscan detection#128
Open
ghost wants to merge 9 commits intofeature/inspection-frameworkfrom
Open
Conversation
Add primitive encryption detection system
aa5237a to
cc0664d
Compare
ppacher
suggested changes
Aug 11, 2020
Contributor
ppacher
left a comment
There was a problem hiding this comment.
Thanks for that contribution @Raskaro! π
I just did an technical review (no testing yet) and added some comments and change requests. Please have a look before we can merge them to the inspection branch. I'll try to test ASAP π
dhaavi
requested changes
Aug 13, 2020
1e901b5 to
846e6cc
Compare
ce67f03 to
85feeb3
Compare
85feeb3 to
0c6a7fc
Compare
Author
|
@ppacher I pushed the final changes. Re-Review when you have time. |
|
Safing seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
7cd8005 to
efec52b
Compare
|
I know this is very old but is there a reason this is hanging about? Seems like it was quite close to being ready...two years ago π |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented a Portscan detection.