New lint: collapsible_tuple_let#16871
Open
Souradip121 wants to merge 9 commits intorust-lang:masterfrom
Open
Conversation
Collaborator
|
r? @llogiq rustbot has assigned @llogiq. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
Lintcheck changes for 9955051
This comment will be updated if you push new changes |
4af99ed to
4f5e8af
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
collapsible_tuple_letlint (style, warn-by-default).Detects
let (a, b) = { let x = expr; (x, expr2) };where the blockis unnecessary — the expressions are fully separable and can be written
as individual
letstatements.Closes #16750
What the lint catches
Conservative conditions (no false positives)
The lint is skipped when:
(would reorder side effects)
letcarries a type annotation orlet-elsechangelog: [
collapsible_tuple_let]: Warn when alettuple destructuring can be collapsed into individualletstatements by removing an unnecessary block expression.