Emit correct monikers for definitions nested in a function#22153
Open
sanxiyn wants to merge 2 commits intorust-lang:masterfrom
Open
Emit correct monikers for definitions nested in a function#22153sanxiyn wants to merge 2 commits intorust-lang:masterfrom
sanxiyn wants to merge 2 commits intorust-lang:masterfrom
Conversation
rustbot
added
the
S-waiting-on-review
| identifier: &str, | ||
| package: &str, | ||
| kind: MonikerKind, | ||
| expected_list: &[(&str, &str, MonikerKind)], |
Member
There was a problem hiding this comment.
Though this is used for tests only, the meaning of each tuple field is a bit confusing, as the first two has the same type.
Could you define a new struct for this or just comment the meaning of each field at least?
Member
|
And could you squash the commits once you have finished? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle definitions in "block modules". I followed hints in #18771.
Fix #18771
Fix #22089