Skip to content

internal: Remove some Arcs#22131

Open
ChayimFriedman2 wants to merge 1 commit intorust-lang:masterfrom
ChayimFriedman2:remove-arcs
Open

internal: Remove some Arcs#22131
ChayimFriedman2 wants to merge 1 commit intorust-lang:masterfrom
ChayimFriedman2:remove-arcs

Conversation

@ChayimFriedman2
Copy link
Copy Markdown
Contributor

Unfortunately, this causes Semantics to become invariant over its lifetime, which necessitates large changes, but the changes from hir downwards are mechanical and could use a skim review.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 21, 2026
@ChayimFriedman2 ChayimFriedman2 force-pushed the remove-arcs branch 2 times, most recently from 0b78b82 to 1fe252c Compare April 21, 2026 23:24
@rustbot

This comment has been minimized.

@rustbot

This comment has been minimized.

@rustbot

This comment has been minimized.

Unfortunately, this causes `Semantics` to become invariant over its lifetime, which necessitates large changes, but the changes from `hir` downwards are mechanical and could use a skim review.
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 22, 2026

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Copy link
Copy Markdown
Member

@Shourya742 Shourya742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look fine. I have very limited understanding or context prior to this PR. We are adding a separate, specific lifetime to the database types and removing the Arc-based variant of SpanMap. Could you please explain?

View changes since this review

@ChayimFriedman2
Copy link
Copy Markdown
Contributor Author

We prefer queries to return references because that's cheaper and Copy. Old salsa couldn't do that, but new salsa can.

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 23, 2026

☔ The latest upstream changes (possibly #22146) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants