switch out lsp-types for gen-lsp-types#22115
Open
BenjaminBrienen wants to merge 4 commits intorust-lang:masterfrom
Open
switch out lsp-types for gen-lsp-types#22115BenjaminBrienen wants to merge 4 commits intorust-lang:masterfrom
BenjaminBrienen wants to merge 4 commits intorust-lang:masterfrom
Conversation
rustbot
added
the
S-waiting-on-review
BenjaminBrienen
force-pushed
the
gen-lsp-types
branch
from
266f7ac to
207d300
Compare
ribru17
reviewed
Apr 22, 2026
DropDemBits
reviewed
Apr 23, 2026
BenjaminBrienen
force-pushed
the
gen-lsp-types
branch
from
b996006 to
e887c95
Compare
This comment has been minimized.
This comment has been minimized.
BenjaminBrienen
force-pushed
the
gen-lsp-types
branch
from
db9f359 to
97d9e55
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
BenjaminBrienen
force-pushed
the
gen-lsp-types
branch
from
97d9e55 to
552f6d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked on:
From<&str>for string enums with custom values ribru17/gen-lsp-types#8LspRequestMethods::Customshould take a&'static strribru17/gen-lsp-types#9crate::Idandcrate::generated::Idribru17/gen-lsp-types#10mod json_rpcto avoid name collisions ribru17/gen-lsp-types#11Alternative to: #22108