Added asynchronous pwm functionality#25
Added asynchronous pwm functionality#25lucavezoc wants to merge 20 commits intorust-embedded:masterfrom
Conversation
Co-authored-by: Ryan <ryankurte@users.noreply.github.com>
| readme = "README.md" | ||
|
|
||
| [dependencies] | ||
| tokio = { version = "1", features = ["full"] } No newline at end of file |
There was a problem hiding this comment.
Using the full feature set is an antipattern in libraries per the tokio docs. Could you please reduce this to just the needed features?
nastevens
left a comment
There was a problem hiding this comment.
@rust-embedded/embedded-linux I think I'd like to see this published as a separate crate sysfs-pwm-async. We'd still add the code to this repo, just with its own Cargo.toml. Thoughts?
|
Putting it in a separate crate seems fine to me since at least the current version does not share anything with the blocking version other than the error type. |
How would I go about doing that? |
Hey sorry for the delay @lucaVuitton, I had planned to make this change but there's been some things in my personal life that are taking priority. If you want to take a try at it, a good place to start would be looking at the structure of the |
No description provided.