Add cast to boolean for cm_topic component#64
Merged
christophfroehlich merged 12 commits intomainfrom Dec 3, 2025
Merged
Conversation
This reverts commit bb7c235.
Member
Author
|
I changed it to switch locally as pre request of @saikishor. An alternative to doing this in the framework ros-controls/ros2_control#2857 |
saikishor
reviewed
Nov 25, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64 +/- ##
==========================================
+ Coverage 78.23% 78.46% +0.23%
==========================================
Files 6 6
Lines 441 455 +14
Branches 45 45
==========================================
+ Hits 345 357 +12
- Misses 66 69 +3
+ Partials 30 29 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
MarqRazz
approved these changes
Nov 26, 2025
Collaborator
MarqRazz
left a comment
There was a problem hiding this comment.
Changes look good. Maybe have a debug log for unsupported datatypes that way it's a little easier for people to see whats wrong without having to dig through the source code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bags recorded with ros-controls/ros2_control#2633 will fail now due to bad variant access.
Needs: ros-controls/ros2_control#2831