Open
Conversation
Author
|
PR is ready for review, from the requested checks just couldn't check if the other workflows passes, because they are awaiting approval |
Member
|
CI kicked off! |
Author
|
hey @bmagyar I believe that the tests didn't pass before because my branch was outdated but I have merged the new changes on it. |
Author
|
@bmagyar friendly ping, can you kick the CI off again? |
72ca142 to
a113bd1
Compare
Signed-off-by: Daniel Mascarenhas <danmascandrade@gmail.com> Signed-off-by: Daniel Mascarenhas <daniel.mascarenhas@saipem.com>
Signed-off-by: Daniel Mascarenhas <danmascandrade@gmail.com> Signed-off-by: Daniel Mascarenhas <daniel.mascarenhas@saipem.com>
1b2e4f0 to
ac32bf1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #357
Summary
Add tests for ros2 control CLI verbs under 'controller_manager/test', using the existing local controller_manager test setup instead of depending on ros2_control_demos.
The new tests cover CLI behavior for:
Files added:
Testing
Contributions via pull requests are much appreciated. Before sending us a pull request, please ensure that:
To send us a pull request, please:
colcon testandpre-commit run(requires you to install pre-commit bypip3 install pre-commit)