Skip to content

[ROB-3712] add correct holmes url if not defined#2050

Merged
moshemorad merged 1 commit intomasterfrom
multiple-runners-holmesurl-fix
Apr 16, 2026
Merged

[ROB-3712] add correct holmes url if not defined#2050
moshemorad merged 1 commit intomasterfrom
multiple-runners-holmesurl-fix

Conversation

@Avi-Robusta
Copy link
Copy Markdown
Contributor

No description provided.

@Avi-Robusta Avi-Robusta changed the title [ROB-0000] add correct rl if not defined [ROB-0000] add correct url if not defined Apr 16, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 16, 2026

Walkthrough

Adds conditional logic to the Helm template's global configuration to automatically populate holmes_url when HolmesGPT is enabled and no URL is explicitly provided, constructing it from the chart name, release namespace, and cluster domain targeting port 80.

Changes

Cohort / File(s) Summary
Helm Template Configuration
helm/robusta/templates/_helpers.tpl
Added conditional logic to global_config that automatically sets holmes_url using chart metadata and cluster domain when enableHolmesGPT is enabled and no explicit URL is provided.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess relevance to the changeset. Add a description explaining the purpose and context of this change, such as why holmes_url needs to be conditionally set.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title accurately describes the main change: conditionally setting the Holmes URL in the Helm template when not already defined.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch multiple-runners-holmesurl-fix

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 16, 2026

Docker image ready for 808dcbe (built in 3m 48s)

⚠️ Warning: does not support ARM (ARM images are built on release only - not on every PR)

Use this tag to pull the image for testing.

📋 Copy commands

⚠️ Temporary images are deleted after 30 days. Copy to a permanent registry before using them:

gcloud auth configure-docker us-central1-docker.pkg.dev
docker pull us-central1-docker.pkg.dev/robusta-development/temporary-builds/robusta-runner:808dcbe
docker tag us-central1-docker.pkg.dev/robusta-development/temporary-builds/robusta-runner:808dcbe me-west1-docker.pkg.dev/robusta-development/development/robusta-runner-dev:808dcbe
docker push me-west1-docker.pkg.dev/robusta-development/development/robusta-runner-dev:808dcbe

Patch Helm values in one line:

helm upgrade --install robusta robusta/robusta \
  --reuse-values \
  --set runner.image=me-west1-docker.pkg.dev/robusta-development/development/robusta-runner-dev:808dcbe

@Avi-Robusta Avi-Robusta changed the title [ROB-0000] add correct url if not defined [ROB-3712] add correct url if not defined Apr 16, 2026
@Avi-Robusta Avi-Robusta changed the title [ROB-3712] add correct url if not defined [ROB-3712] add correct holmes url if not defined Apr 16, 2026
@moshemorad moshemorad merged commit c22a51e into master Apr 16, 2026
7 checks passed
@moshemorad moshemorad deleted the multiple-runners-holmesurl-fix branch April 16, 2026 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants