Skip to content

Added optional func-of to WARL/WLRL schema.#238

Merged
james-ball-qualcomm merged 4 commits intomainfrom
add_func_of
Mar 26, 2026
Merged

Added optional func-of to WARL/WLRL schema.#238
james-ball-qualcomm merged 4 commits intomainfrom
add_func_of

Conversation

@james-ball-qualcomm
Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: James Ball <jameball@qti.qualcomm.com>
@james-ball-qualcomm james-ball-qualcomm self-assigned this Mar 26, 2026
Copilot AI review requested due to automatic review settings March 26, 2026 22:30
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for expressing WARL/WLRL CSR/field legal values as a function of another CSR/field, carrying that metadata through YAML → params.json and surfacing it in generated HTML/AsciiDoc CSR tables.

Changes:

  • Extend CSR definition/input and params.json/output schemas to allow optional func-of-reg-name / func-of-field-name.
  • Propagate the new fields through tools/create_params.py output and render func-of: <reg>[.<field>] in the CSR Type column for HTML and AsciiDoc.
  • Update docs and golden tests/fixtures to cover the new fields and rendering.

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tools/create_params.py Parses and emits func-of-* for CSR entries; renders func-of: in HTML CSR tables.
tools/create_csr_appendix.py Renders func-of: in the AsciiDoc CSR appendix Type cell.
tools/README.md Documents the new CSR definition properties and output behavior.
schemas/param-common-schema.json Adds shared schema defs funcOfRegName / funcOfFieldName.
schemas/param-defs-schema.json Allows func-of-* in csr_definitions input entries.
schemas/params-schema.json Allows func-of-* in csrs output entries.
tests/params/test-ch2.yaml Adds a CSR test case using func-of-*.
tests/params/expected/test-params.json Updates expected params.json to include func-of-* and updated text.
tests/params/expected/test-params.html Updates expected HTML to show func-of: in the Type column.
tests/params/expected/test-csr-table-variants/test-csr-table-reordered/test-ch2/foo.ABC.adoc Updates expected AsciiDoc fragment to include func-of:.
tests/params/expected/test-csr-table-variants/test-csr-table-full-default/test-ch2/foo.ABC.adoc Updates expected AsciiDoc fragment to include func-of:.
tests/params/expected/test-csr-appendix-adoc-includes/test-ch2/foo.ABC.adoc Updates expected AsciiDoc fragment to include func-of:.
tests/norm-rule/test-ch2.adoc Updates normative rule text used by tests.
tests/norm-rule/expected/test-norm-rules.json Updates expected normative rules JSON text.
tests/norm-rule/expected/test-norm-rules.html Updates expected normative rules HTML text.
tests/norm-rule/expected/test-ch2-norm-tags.json Updates expected tag JSON text.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tools/create_params.py
Comment thread tools/create_csr_appendix.py Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: James Ball <jameball@qti.qualcomm.com>
Signed-off-by: James Ball <jameball@qti.qualcomm.com>
Signed-off-by: James Ball <jameball@qti.qualcomm.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@james-ball-qualcomm james-ball-qualcomm merged commit 78567fd into main Mar 26, 2026
6 checks passed
@james-ball-qualcomm james-ball-qualcomm deleted the add_func_of branch March 26, 2026 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants