Added optional func-of to WARL/WLRL schema.#238
Merged
james-ball-qualcomm merged 4 commits intomainfrom Mar 26, 2026
Merged
Conversation
Signed-off-by: James Ball <jameball@qti.qualcomm.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for expressing WARL/WLRL CSR/field legal values as a function of another CSR/field, carrying that metadata through YAML → params.json and surfacing it in generated HTML/AsciiDoc CSR tables.
Changes:
- Extend CSR definition/input and params.json/output schemas to allow optional
func-of-reg-name/func-of-field-name. - Propagate the new fields through
tools/create_params.pyoutput and renderfunc-of: <reg>[.<field>]in the CSR Type column for HTML and AsciiDoc. - Update docs and golden tests/fixtures to cover the new fields and rendering.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/create_params.py | Parses and emits func-of-* for CSR entries; renders func-of: in HTML CSR tables. |
| tools/create_csr_appendix.py | Renders func-of: in the AsciiDoc CSR appendix Type cell. |
| tools/README.md | Documents the new CSR definition properties and output behavior. |
| schemas/param-common-schema.json | Adds shared schema defs funcOfRegName / funcOfFieldName. |
| schemas/param-defs-schema.json | Allows func-of-* in csr_definitions input entries. |
| schemas/params-schema.json | Allows func-of-* in csrs output entries. |
| tests/params/test-ch2.yaml | Adds a CSR test case using func-of-*. |
| tests/params/expected/test-params.json | Updates expected params.json to include func-of-* and updated text. |
| tests/params/expected/test-params.html | Updates expected HTML to show func-of: in the Type column. |
| tests/params/expected/test-csr-table-variants/test-csr-table-reordered/test-ch2/foo.ABC.adoc | Updates expected AsciiDoc fragment to include func-of:. |
| tests/params/expected/test-csr-table-variants/test-csr-table-full-default/test-ch2/foo.ABC.adoc | Updates expected AsciiDoc fragment to include func-of:. |
| tests/params/expected/test-csr-appendix-adoc-includes/test-ch2/foo.ABC.adoc | Updates expected AsciiDoc fragment to include func-of:. |
| tests/norm-rule/test-ch2.adoc | Updates normative rule text used by tests. |
| tests/norm-rule/expected/test-norm-rules.json | Updates expected normative rules JSON text. |
| tests/norm-rule/expected/test-norm-rules.html | Updates expected normative rules HTML text. |
| tests/norm-rule/expected/test-ch2-norm-tags.json | Updates expected tag JSON text. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: James Ball <jameball@qti.qualcomm.com>
Signed-off-by: James Ball <jameball@qti.qualcomm.com>
Signed-off-by: James Ball <jameball@qti.qualcomm.com>
0768ca2 to
79e20df
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 19 out of 19 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.