Skip to content

091dev#6349

Open
adhami3310 wants to merge 2 commits intomainfrom
091dev
Open

091dev#6349
adhami3310 wants to merge 2 commits intomainfrom
091dev

Conversation

@adhami3310
Copy link
Copy Markdown
Member

No description provided.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 21, 2026

Merging this PR will not alter performance

βœ… 9 untouched benchmarks


Comparing 091dev (8cbbc88) with main (0d9f0c5)

Open in CodSpeed

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 21, 2026

Greptile Summary

This PR is a dependency refresh cycle, bumping Bun, React, React Router, Vite, Tailwind, Recharts, Plotly, lodash, lucide-react, and several other packages, alongside a restructured .pre-commit-config.yaml (switching to repo: local hooks, adding codespell, extending ruff-format to Markdown) and minor code formatting from ruff-preview.

  • P1 – broken test assertion: test_nested_function in test_dep_tracking.py removes the only self.board reference from the inner function body but keeps \"board\" in expected_deps, which will cause the test to fail.
  • P1 – lucide-react v1 breaking change: Upgrading from 0.577.0 to 1.8.0 removes 14 brand icons (github, gitlab, facebook, instagram, linkedin, figma, etc.) that existing Reflex apps may be using. This should be surfaced in a changelog entry before the release.

Confidence Score: 4/5

Hold for the stale expected_deps in the dep-tracking test and a missing changelog note on the lucide-react v1 brand-icon removal before merging.

Two P1 findings: a likely test failure in test_dep_tracking.py (wrong expected_deps after removing self.board), and a breaking change (brand icons dropped in lucide-react v1) that should be documented. All remaining findings are P2.

tests/units/vars/test_dep_tracking.py (stale assertion), packages/reflex-components-lucide/src/reflex_components_lucide/icon.py (breaking icon removal)

Important Files Changed

Filename Overview
tests/units/vars/test_dep_tracking.py Removed self.board from nested inner function body but expected_deps still asserts "board" is tracked β€” test will likely fail.
packages/reflex-components-lucide/src/reflex_components_lucide/icon.py lucide-react bumped 0.577.0β†’1.8.0 (major version); 14 brand icons removed from LUCIDE_ICON_LIST β€” intentional but breaking for existing users.
packages/reflex-base/src/reflex_base/constants/installer.py Routine dependency version bumps: Bun 1.3.10β†’1.3.13, React Router 7.13.1β†’7.14.1, React 19.2.4β†’19.2.5, isbot, autoprefixer, postcss, vite.
packages/reflex-components-plotly/src/reflex_components_plotly/plotly.py All plotly.js dist-min variants bumped from 3.4.0β†’3.5.0 consistently.
pyproject.toml rich upper-bound bumped <15β†’<16; codespell added to dev deps; codespell skip patterns updated; pyright excludes reorganised.
.pre-commit-config.yaml Restructured to repo:local hooks; ruff-format now covers markdown files; pyright no longer version-pinned (was v1.1.408).
tests/units/compiler/test_compiler.py Imports updated to use direct module paths (Links, Meta, Scripts, Html, Head) instead of re-exported names from utils β€” no logic changes.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[PR: 091dev dependency refresh] --> B[Frontend deps bumped]
    A --> C[Python deps bumped]
    A --> D[Pre-commit restructured]
    A --> E[Test changes]

    B --> B1[lucide-react 0.577.0 β†’ 1.8.0\n⚠️ brand icons removed]
    B --> B2[plotly.js 3.4.0 β†’ 3.5.0]
    B --> B3[recharts 3.8.0 β†’ 3.8.1]
    B --> B4[lodash 4.17.23 β†’ 4.18.1]
    B --> B5[tailwindcss 4.2.2 β†’ 4.2.3]
    B --> B6[vite 8.0.0 β†’ 8.0.9 / react 19.2.4 β†’ 19.2.5 / bun 1.3.10 β†’ 1.3.13]

    C --> C1[rich < 15 β†’ < 16]
    C --> C2[codespell added to dev deps]

    D --> D1[repo:local for ruff/pyright/codespell\npyright no longer version-pinned]
    D --> D2[ruff-format now covers Markdown]

    E --> E1[Remove noqa: RUF029 across tests]
    E --> E2[test_dep_tracking: remove self.board\n⚠️ expected_deps not updated]
Loading

Comments Outside Diff (1)

  1. tests/units/vars/test_dep_tracking.py, line 285-286 (link)

    P1 Stale expected dependency after removing self.board reference

    expected_deps still asserts "board" is tracked, but self.board was just removed from the inner function body β€” the only place it appeared. With the inner function now containing only pass, the dependency tracker has no code path through which it could encounter board. This assertion is likely wrong and the test will fail.

Reviews (1): Last reviewed commit: "091dev" | Re-trigger Greptile

Comment thread .pre-commit-config.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant