Skip to content

Fixes Windows CI: prepend '/c/Program Files/Git/bin'#2611

Merged
jordwalke merged 3 commits intoreasonml:masterfrom
ManasJayanth:fix-windows-ci-prepend-git-bash
Jul 26, 2020
Merged

Fixes Windows CI: prepend '/c/Program Files/Git/bin'#2611
jordwalke merged 3 commits intoreasonml:masterfrom
ManasJayanth:fix-windows-ci-prepend-git-bash

Conversation

@ManasJayanth
Copy link
Copy Markdown
Contributor

Bash@3 started failing after a recent change related to WSL

actions/runner-images#1081
actions/runner-images#1276

This PR ensure bash.exe is picked from Git Bash

@ManasJayanth
Copy link
Copy Markdown
Contributor Author

Thanks @-phated for the idea

@ManasJayanth
Copy link
Copy Markdown
Contributor Author

🙌

@jordwalke
Copy link
Copy Markdown
Member

Thank you @phated and @prometheansacrifice. I incorporated the fixes into this PR:
#2605
I'll merge the other one if it's ready within the day, else merge this one.

@jordwalke jordwalke merged commit d3822b7 into reasonml:master Jul 26, 2020
@ManasJayanth ManasJayanth deleted the fix-windows-ci-prepend-git-bash branch August 6, 2020 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants