Support single line comments of the form // comment#2254
Merged
chenglou merged 2 commits intoreasonml:masterfrom Nov 13, 2018
Merged
Support single line comments of the form // comment#2254chenglou merged 2 commits intoreasonml:masterfrom
// comment#2254chenglou merged 2 commits intoreasonml:masterfrom
Conversation
IwanKaramazow
force-pushed
the
SingleLineComments
branch
from
2350d55 to
078f6c7
Compare
kpsuperplane
reviewed
Nov 1, 2018
IwanKaramazow
force-pushed
the
SingleLineComments
branch
2 times, most recently
from
780b19e to
d7ac64a
Compare
```reason
let x = {
//
};
```
If the { }-sequence didn't break we would get parse error:
```reason
let x = { // };
```
IwanKaramazow
force-pushed
the
SingleLineComments
branch
from
d7ac64a to
ffeb8ad
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements parsing & printing of single line comments.
Example:
The main logic is taken from #1800.
Extra test cases and support for whitespace interleaving have been implemented.