Skip to content

Moderator changes minor refactor#3340

Merged
jb3 merged 3 commits intomainfrom
jb3/mod-changes-refactor
Jun 25, 2025
Merged

Moderator changes minor refactor#3340
jb3 merged 3 commits intomainfrom
jb3/mod-changes-refactor

Conversation

@jb3
Copy link
Copy Markdown
Member

@jb3 jb3 commented Jun 24, 2025

Refactors some items from #3339 and #3338.

  • Use partial objects to avoid unnecessary API calls when tidying up infraction messages
    • I hadn't noticed the partial functions when I went on my hunt, I was working under the assumption I'd have to hook into the HTTP stuff or create my own partials, but this is much cleaner and cheaper.
  • Don't tidy-up infractions outside mod channels (ensures that infractions issued by the bot automatically in mod-alerts stay as part of the context)
  • Exclude the bot-commands channel from the !rule usage alerts.

@jb3 jb3 requested a review from mbaruh as a code owner June 24, 2025 23:32
@jb3 jb3 enabled auto-merge June 25, 2025 10:32
Copy link
Copy Markdown
Contributor

@wookie184 wookie184 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jb3 jb3 merged commit 45ced59 into main Jun 25, 2025
5 checks passed
@jb3 jb3 deleted the jb3/mod-changes-refactor branch June 25, 2025 10:59
@sentry
Copy link
Copy Markdown

sentry Bot commented Jun 25, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants