Skip to content

Simplify PEP cog to use PEP API#3309

Merged
ChrisLovering merged 4 commits intomainfrom
update-pep-cog-2
May 31, 2025
Merged

Simplify PEP cog to use PEP API#3309
ChrisLovering merged 4 commits intomainfrom
update-pep-cog-2

Conversation

@wookie184
Copy link
Copy Markdown
Contributor

Take 2 of #2166, as the API is now documented (https://peps.python.org/api/)

Also, closes #3183 by refreshing the cache periodically regardless of whether the PEP is already cached.

@wookie184 wookie184 added t: bug Something isn't working t: enhancement Changes or improvements to existing features s: needs review Author is waiting for someone to review and approve labels Apr 9, 2025
vivekashok1221

This comment was marked as duplicate.

Copy link
Copy Markdown
Member

@vivekashok1221 vivekashok1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌟

Comment thread bot/exts/info/pep.py Outdated
@wookie184 wookie184 added the review: do not merge The PR can be reviewed but cannot be merged now label Apr 16, 2025
@wookie184 wookie184 removed the review: do not merge The PR can be reviewed but cannot be merged now label Apr 19, 2025
Copy link
Copy Markdown
Member

@vivekashok1221 vivekashok1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌟

@ChrisLovering ChrisLovering merged commit 4047c71 into main May 31, 2025
5 checks passed
@ChrisLovering ChrisLovering deleted the update-pep-cog-2 branch May 31, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

s: needs review Author is waiting for someone to review and approve t: bug Something isn't working t: enhancement Changes or improvements to existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

!pep incorrectly returns status of PEP

3 participants