allow editing op name and args after init#245
allow editing op name and args after init#245pwyllcrusader wants to merge 2 commits intoprofusion:masterfrom
Conversation
|
@barbieri sorry, I'm a bit new to such activities. is there anything else I have to do in order to add getter/setters to Operation class? |
|
let's see if the tests pass... I'm bit out of time these days, so may take a while for me to come back with anything more concrete about your code. All in all, as I said in #244 I think it would be better to create a function that takes the parameters and create the Operation object instead of mutating it. |
That's how I did but this approach adds one (or 2, don't quite remember) more line per test. If there are hundreds of them it's quite significant. Definitely it's not critical but adding setters sounded to me like not big deal as well |
|
ok, we'll need to add a test to cover it, as you can see the coverage dropped and we need to keep it 100% for that file. |
|
(I rebased your branch using github UI, I had to do it since 3.7 tests were broken, so did move to python >=3.8 and bumped other deps... fetch, rebase and reinstall all your deps with poetry) |
Description
Related Issues
#244
Progress
Pull request checklist
How to test it
Visual reference