Develop codemirror v6#4067
Develop codemirror v6#4067mmendieta2 wants to merge 7 commits intoprocessing:develop-codemirror-v6from
Conversation
Co-authored-by: Diego Salvaleon <dsalvaleon1@toromail.csudh.edu>
Release EnvironmentsThis Environment is provided by Release, learn more! 🔧Environment Status : https://app.release.com/public/Processing%20Foundation/env-3af4535a2a |
| expect(div).not.toBeNull(); | ||
| }); | ||
|
|
||
| it('Enables line wrap', () => { |
There was a problem hiding this comment.
is this the same test as the one above?
| expect(div).toBeNull(); | ||
| }); | ||
|
|
||
| it('Enable autocomplete', () => { |
There was a problem hiding this comment.
I don't think you will see any autocompletion results if 1. the file content is empty (thus nothing to autocomplete) and 2. the cursor is not near the item to be autocompleted. i think the initial file state would need to be updated to trigger an autocomplete modal, but to be honest if it's too complex we can omit these tests to start with.
| expect(div).not.toHaveAttribute('aria-autocomplete', 'list'); | ||
| }); | ||
|
|
||
| it('Enables autoclose brackets and quotes', () => { |
There was a problem hiding this comment.
same here, there will be nothing to "autoclose" if there is no content. I also wonder if autoclose only triggers when you send a typing event like "user just typed ["
|
Hi! Thank you so much, testing was definitely greatly needed! I noticed the new test file fails, would you be able to take a second look at some of the failing tests? I took a look and left some comments about why i think they may be failing, but only took a pass through the first few so the others after may also need to be addressed. thanks! |
5 participants
Issue: #3869
Fixes #
Added tests for stateUtils.js. Testing for file types were added, with no issues. Testing for user prefences were added, although the "autocomplete" div does not get the property "aria-autocomplete" upon creation of the fileState. Testing for tidy code was added, but the keymap itself does not trigger.
Changes:
A new file named stateUtils.test.js was created for testing.
I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #123