Pin GitHub Actions to full commit SHAs#4368
Open
Xeboc wants to merge 1 commit intopeter-evans:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins all
uses:references in workflow files to full commit SHAs. This allows users with org-level or repo-level SHA enforcement policies to use this action without policy violations caused by unpinned downstream dependencies.This came up while working on a similar change to
trunk-io/trunk-action(trunk-io/trunk-action#291), where trunk pulls increate-pull-request. Even when trunk itself is pinned to a full SHA, the enforcement policy still fails on unpinneduses:in its dependencies:Unpinned action references are also a supply chain risk, as a tag can be moved to point to a different commit at any time. The recent Trivy advisory is a good example of how this attack surface gets exploited in practice.
If this one is merged, would you also accept PRs for the rest of your published actions? Dependabot will upgrade these SHAs automatically when it runs. Pinact was used to find these SHAs quickly.