Add test for precision conversion with decl_hdf5#672
Open
Yushan-Wang wants to merge 72 commits intopdidev:mainfrom
Open
Add test for precision conversion with decl_hdf5#672Yushan-Wang wants to merge 72 commits intopdidev:mainfrom
decl_hdf5#672Yushan-Wang wants to merge 72 commits intopdidev:mainfrom
Conversation
Removed check for HDF5 version greater than 2.0.0 and related variable assignment.
…ushan-Wang/pdi into precision-conversion-with-hdf5
059513f to
12dff81
Compare
Member
|
Do you feel it would be a good candidate to demonstrate the use of #669 ? |
…into patch-hdf5-2.0.0
Co-authored-by: Julien Bigot <jbigot@users.noreply.github.com>
Co-authored-by: Julien Bigot <jbigot@users.noreply.github.com>
jbigot
reviewed
Apr 17, 2026
jbigot
reviewed
Apr 17, 2026
jmorice91
reviewed
Apr 20, 2026
jbigot
previously approved these changes
Apr 20, 2026
jmorice91
reviewed
Apr 20, 2026
Contributor
jmorice91
left a comment
There was a problem hiding this comment.
look goods for me.
If your input double data is 1.5d0=1.50...0, how to know that the convention between HDF5 and gtest for transformation of double to int is the same?
Have you tested that?
As we use random number, it is a rare event that is arrived.
Member
Author
HDF5 truncates floating-point numbers to integers upon precision conversion. So 1.5 would be output as 1. Same for static_cast |
jbigot
reviewed
Apr 20, 2026
c257c27 to
ce93f25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List of things to check before making a PR
Before merging your code, please check the following:
.clang-format;Fix #issuekeyword to autoclose the issue when merged.